Skip to content

719: Added route to send test discord message to club#757

Open
Arshadul-Monir wants to merge 4 commits intomainfrom
719
Open

719: Added route to send test discord message to club#757
Arshadul-Monir wants to merge 4 commits intomainfrom
719

Conversation

@Arshadul-Monir
Copy link
Collaborator

@Arshadul-Monir Arshadul-Monir commented Feb 10, 2026 •
edited
Loading

719

Description of changes

Added an admin-only POST route that takes a clubId and sends a test message to the Discord guild associated with a club, given its clubId, in the channel associated with the channelId stored for them

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Test message using the /api/admin/discord/message/test endpoint:
image

Message deleted using the /api/admin/discord/message/delete:
image

Staging

Test message using the /api/admin/discord/message/test endpoint:
image

Message deleted using the /api/admin/discord/message/delete:
image

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Title

719: Added route to send test discord message to club

PR Type

Enhancement

Description

  • Add admin POST /admin/discord/message/test endpoint

  • Send test embed to club leaderboard channel

  • Validate admin session and return status

  • Implement manager method to construct embed

Diagram Walkthrough

flowchart LR
  A["AdminController POST /admin/discord/message/test"] --> B["DiscordClubManager.sendTestEmbedMessageToClub"]
  B --> C["JDA Client connect/send"]
  C --> D["Discord Guild Leaderboard Channel"]
Loading

File Walkthrough
Relevant files
Enhancement
AdminController.java
Introduce admin Discord test message endpoint                       

src/main/java/org/patinanetwork/codebloom/api/admin/AdminController.java

  • Add POST /admin/discord/message/test endpoint
  • Validate admin via protector.validateAdminSession
  • Delegate to discordClubManager.sendTestEmbedMessageToClub
  • Return success or 500 with ApiResponder
 +24/-0   
DiscordClubManager.java
Add method to send Discord test embed                                       

src/main/java/org/patinanetwork/codebloom/common/components/DiscordClubManager.java

  • Implement sendTestEmbedMessageToClub(String clubId)
  • Connect JDA, fetch club and metadata IDs
  • Build and send embed via EmbeddedImagesMessageOptions
  • Handle exceptions and return boolean status
 +37/-0   

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

AC Not Met

The test message is never deleted after 10 seconds and no message ID is stored in memory, both of which are required by the acceptance criteria. Capture the sent message ID, schedule deletion after 10 seconds, and keep temporary in-memory storage for these IDs.

 
    jdaClient.sendEmbedWithImages(EmbeddedImagesMessageOptions.builder()
            .guildId(Long.valueOf(guildId.get()))
            .channelId(Long.valueOf(channelId.get()))
            .description(description)
            .title("Message for %s"
                    .formatted(club.getName()))
            .footerText("Codebloom - LeetCode Leaderboard for %s".formatted(club.getName()))
            .footerIcon("%s/favicon.ico".formatted(serverUrlUtils.getUrl()))
            .color(new Color(69, 129, 103))
            .build());
    return true;
} catch (Exception e){
Possible Issue

Optional values for guildId and channelId are dereferenced without presence checks, which can throw at runtime. Validate presence and return a meaningful error if either is missing.

 
var guildId = club.getDiscordClubMetadata().flatMap(DiscordClubMetadata::getGuildId);
var channelId = club.getDiscordClubMetadata().flatMap(DiscordClubMetadata::getLeaderboardChannelId);

jdaClient.sendEmbedWithImages(EmbeddedImagesMessageOptions.builder()
        .guildId(Long.valueOf(guildId.get()))
        .channelId(Long.valueOf(channelId.get()))
        .description(description)
API Contract Mismatch

The endpoint consumes a raw string instead of a JSON DTO with clubId and returns 500 for all failures while the Swagger docs declare 404. Validate input, return 400 for bad input and 404 when the club is not found, and align annotations with actual responses.

 
@PostMapping("/discord/message/test")
public ResponseEntity<ApiResponder<Empty>> sendDiscordMessage(@RequestBody final String clubId, final HttpServletRequest request) {
    protector.validateAdminSession(request);
    boolean sentMessage = discordClubManager.sendTestEmbedMessageToClub(clubId);

    if (!sentMessage) {
        return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR)
                .body(ApiResponder.failure("Hmm, something went wrong."));
    }
    return ResponseEntity.ok(ApiResponder.success("Message successfully sent!", Empty.of()));
}

@Arshadul-Monir Arshadul-Monir force-pushed the 719 branch 4 times, most recently from 9532462 to ba9ef51 Compare February 10, 2026 18:48
@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 10, 2026

/deploy

@Arshadul-Monir Arshadul-Monir force-pushed the 719 branch 4 times, most recently from 4d13e0f to eeea043 Compare February 11, 2026 17:36
@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 11, 2026

/deploy

@Arshadul-Monir Arshadul-Monir force-pushed the 719 branch 15 times, most recently from 5d6b910 to 3b5f844 Compare February 16, 2026 04:37
@Arshadul-Monir
719: Added route to send test discord message to club
9e3b3be 
719: Admin message deletes self after 10 seconds
@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 17, 2026

/deploy

@Arshadul-Monir
719: Added backend tests
c73129e 
719: Added tests for sendDiscordMessage

719: Updated mockio test

719: Added tests for JDAClient

719: Added private to setup functions

719: Added delete test

719: Finished AdminController Tests
@Arshadul-Monir
719: Output better messages for invalid or incorrect clubId
9afbc61 
719: Undo auto deletion in DiscordClubManager

719: Removed auto deletion logic from test
@Arshadul-Monir
719: Endpoint to delete discord message
0d52e54
@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 17, 2026

/deploy

2 similar comments
@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 17, 2026

/deploy

@Arshadul-Monir
Copy link
Collaborator Author

Arshadul-Monir commented Feb 17, 2026

/deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Arshadul-Monir