Swapped Hpricot for Nokogiri and updated tests.#6
Open
ericdfields wants to merge 2 commits intoszimek:masterfrom
Open
Swapped Hpricot for Nokogiri and updated tests.#6ericdfields wants to merge 2 commits intoszimek:masterfrom
ericdfields wants to merge 2 commits intoszimek:masterfrom
Conversation
Owner
|
Thanks! I haven't used this gem in a looooong time. People are still using faxes, huh? 😄 I've just noticed that Travis CI runs tests on Ruby 1.8.7, Enterprise Edition and 1.9.2... I have no idea yet why tests don't run, but I maybe it would be good idea to switch to minitest. |
Author
|
@szimek you have no idea how many big businesses still rely on faxes ;-) This is actually just an effort by me to get hpricot out of our Gemfile.lock so that I can use http://github.com/premailer/premailer without it defaulting to hpricot… |
Owner
|
@ericdfields If you can figure out how to actually run tests and they all pass, I'd happy to merge your PR. I'm not sure when I'll have enough free time to investigate it myself... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hpricot is dead so I popped in Nokogiri and updated all instances where Hpricot is used. I ran 'rake' and made sure the tests wouldn't error, but I don't see them running at al. Simply get:
I'm a little unfamiliar w/ how to run the test suite here. Happy to keep pushing this through if there's interest.