Skip to content

Make JS links red #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PizzaTowerFanGD wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −2
Open

Make JS links red #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92768ec
JS links are red now
PizzaTowerFanGD Jan 31, 2026
b1bd30b
YOU'RE red NOW!!! THAT'S MY ATTACK!!!
PizzaTowerFanGD Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/static/yw/javascript/owot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ var combiningCharsEnabled = true;
var surrogateCharsEnabled = true;
var defaultCoordLinkColor = "#008000";
var defaultURLLinkColor = "#0000FF";
var defaultJSLinkColor = "#AA0000"; // compliant with most accessibility standards
var defaultHighlightColor = [0xFF, 0xFF, 0x99];
var secureJSLink = true; // display warning prompt when clicking on javascript links
var secureLink = true; // display confirmation when clicking on links in a suspicious setting
Expand Down
10 changes: 8 additions & 2 deletions frontend/static/yw/javascript/renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,8 @@ function renderChar(textRender, offsetX, offsetY, char, color, cellW, cellH, pro
} else if(linkType == "note") {
isLink = false;
isTooltip = true;
} else if(linkType == "js") {
linkColor = defaultJSLinkColor;
}
}

Expand Down Expand Up @@ -1190,8 +1192,12 @@ function renderContent(textRenderCtx, tileX, tileY, clampW, clampH, offsetX, off
var cellLinkType = null;
if(tileColProps && tileColProps.link) {
cellLinkType = tileColProps.link.type;
if(tileColProps.link.type == "url" && tileColProps.link.url.startsWith("note:")) {
cellLinkType = "note";
if(tileColProps.link.type == "url") {
if(tileColProps.link.url.startsWith("note:")) {
cellLinkType = "note";
} else if(tileColProps.link.url.startsWith("javascript:")) {
cellLinkType = "js";
}
}
}
var protValue = writability;
Expand Down