Features/test real file system

.github/workflows/main.yml

@@ -1,8 +1,10 @@
 name: CI
 on:
   push:
-    branches:
-      - main
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
 jobs:
   build:
     name: test

.gitignore

@@ -1,2 +1,3 @@
 node_modules
+tmp
 .vscode

lib/javascript/prefer-class-properties.js

@@ -84,17 +84,17 @@ new Synvert.Rewriter("javascript", "prefer-class-properties", function () {
           },
         );
 
-        functions.forEach((func) => {
+        for (const func of functions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(func.left.name)} = ${this.mutationAdapter.getSource(func.right, {
               fixIndent: true,
             })}`,
             tabSize,
           );
           insert(`\n\n${source.replace(/function ?/, "").replace(/\) {/, ") => {")}`, { at: "end" });
-        });
+        }
 
-        arrowFunctions.forEach((arrowFunction) => {
+        for (const arrowFunction of arrowFunctions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(arrowFunction.left.name)} = ${this.mutationAdapter.getSource(
               arrowFunction.right,
@@ -103,7 +103,7 @@ new Synvert.Rewriter("javascript", "prefer-class-properties", function () {
             tabSize,
           );
           insert(`\n\n${source}`, { at: "end" });
-        });
+        }
       });
 
       // handleChange() {}

lib/react/prefer-class-properties.js

@@ -99,17 +99,17 @@ new Synvert.Rewriter("react", "prefer-class-properties", () => {
           },
         );
 
-        functions.forEach((func) => {
+        for (const func of functions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(func.left.name)} = ${this.mutationAdapter.getSource(func.right, {
               fixIndent: true,
             })}`,
             tabSize,
           );
           insert(`\n\n${source.replace(/function ?/, "").replace(/\) {/, ") => {")}`, { at: "end" });
-        });
+        }
 
-        arrowFunctions.forEach((arrowFunction) => {
+        for (const arrowFunction of arrowFunctions) {
           const source = indentCode(
             `${this.mutationAdapter.getSource(arrowFunction.left.name)} = ${this.mutationAdapter.getSource(
               arrowFunction.right,
@@ -118,7 +118,7 @@ new Synvert.Rewriter("react", "prefer-class-properties", () => {
             tabSize,
           );
           insert(`\n\n${source}`, { at: "end" });
-        });
+        }
       });
 
       // handleChange() {}

lib/react/transform-class-components-to-functions.js

@@ -55,7 +55,7 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
 
       // state = { key: value };
       findNode(".PropertyDeclaration[name=state]", () => {
-        this.currentNode.initializer.properties.forEach((property) => {
+        for (const property of this.currentNode.initializer.properties) {
           const name = property.name.escapedText;
           const value = this.mutationAdapter.getSource(property.initializer);
           functionBody.push(
@@ -64,7 +64,7 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
               1,
             ),
           );
-        });
+        }
       });
 
       // foo = () => {}
@@ -84,15 +84,15 @@ new Synvert.Rewriter("react", "transform-class-components-to-functions", () => {
       if (lifecycleMethods.length > 0) {
         functionBody.push(addLeadingSpaces("// Synvert TODO: convert lifecycle methods to useEffect by yourself"));
         setUseEffect(currentFilePath);
-        lifecycleMethods.forEach((lifecycleMethod) => {
+        for (const lifecycleMethod of lifecycleMethods) {
           const lines = this.mutationAdapter.getSource(lifecycleMethod, { fixIndent: true }).split("\n");
           functionBody.push(
             indentCode(
               lines.map((line) => (line.length > 0 ? "// " + line : "//")).join("\n"),
               1,
             ),
           );
-        });
+        }
       }
 
       // render() {}

package.json

@@ -22,7 +22,7 @@
   },
   "homepage": "https://github.com/synvert-hq/synvert-snippets-javascript#readme",
   "devDependencies": {
-    "@synvert-hq/synvert-core": "^2.23.0",
+    "@synvert-hq/synvert-core": "^2.24.0",
     "jest": "^27.0.6",
     "mock-fs": "^5.4.0"
   }

test/bun/convert-jest-to-bun.spec.js

@@ -12,11 +12,10 @@ describe(snippet, () => {
     `;
 
     assertConvert({
-      path: "test/foobar.spec.js",
+      path: "test/bun/convert-jest-to-bun.spec.js",
       input,
       output,
       snippet,
-      helpers: ["helpers/add-import"],
     });
   });
 
@@ -39,11 +38,10 @@ describe(snippet, () => {
     `;
 
     assertConvert({
-      path: "test/foobar.spec.js",
+      path: "test/bun/convert-jest-to-bun.spec.js",
       input,
       output,
       snippet,
-      helpers: ["helpers/add-import"],
     });
   });
 
@@ -66,11 +64,10 @@ describe(snippet, () => {
     `;
 
     assertConvert({
-      path: "test/foobar.spec.js",
+      path: "test/bun/convert-jest-to-bun.spec.js",
       input,
       output,
       snippet,
-      helpers: ["helpers/add-import"],
     });
   });
 });

test/javascript/no-unused-imports.spec.js

@@ -17,7 +17,6 @@ describe(snippet, () => {
         const c = a() + b + x() + y();
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -36,7 +35,6 @@ describe(snippet, () => {
         const c = b(x, y);
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -59,7 +57,6 @@ describe(snippet, () => {
         const c = a(y);
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -77,7 +74,6 @@ describe(snippet, () => {
         console.log(y);
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -92,7 +88,6 @@ describe(snippet, () => {
         console.log(c);
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -108,7 +103,6 @@ describe(snippet, () => {
         const c = a() + b;
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -123,7 +117,6 @@ describe(snippet, () => {
         const c = a() + b;
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -138,7 +131,6 @@ describe(snippet, () => {
         p.test();
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -152,7 +144,6 @@ describe(snippet, () => {
         console.log("p");
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -167,7 +158,6 @@ describe(snippet, () => {
         console.log(y);
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
     });
   });
 
@@ -194,8 +184,7 @@ describe(snippet, () => {
         }
       `,
       snippet,
-      helpers: ["helpers/remove-imports"],
-      path: "code.jsx",
+      path: "javascript/no-unused-imports.jsx",
     });
   });
 });

test/javascript/no-useless-constructor.spec.js

@@ -36,6 +36,5 @@ describe(snippet, () => {
     input,
     output,
     snippet,
-    path: "code.js",
   });
 });

test/javascript/prefer-class-properties.spec.js

@@ -65,7 +65,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
     });
   });
 
@@ -99,7 +98,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
     });
   });
 });

test/react/add-autocomplete-attribute.spec.js

@@ -17,7 +17,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
     });
   });
 
@@ -38,7 +37,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
     });
   });
 
@@ -71,7 +69,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
     });
   });
 });

test/react/import-named-component.spec.js

@@ -21,7 +21,7 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
+      path: "react/import-named-component.jsx",
     });
   });
 
@@ -44,7 +44,7 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
+      path: "react/import-named-component.jsx",
     });
   });
 });

test/react/import-prop-types.spec.js

@@ -16,8 +16,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
-      helpers: ["helpers/add-import", "helpers/remove-imports"],
     });
   });
 
@@ -35,8 +33,6 @@ describe(snippet, () => {
       input,
       output,
       snippet,
-      path: "code.jsx",
-      helpers: ["helpers/add-import", "helpers/remove-imports"],
     });
   });
 });

test/react/prefer-class-properties.spec.js

@@ -69,7 +69,5 @@ describe(snippet, () => {
     input,
     output,
     snippet,
-    subSnippets: ["javascript/no-useless-constructor"],
-    path: "code.jsx",
   });
 });

test/react/remove-unused-react-imports.spec.js

@@ -20,7 +20,5 @@ describe(snippet, () => {
     input,
     output,
     snippet,
-    helpers: ["helpers/remove-imports"],
-    path: "code.jsx",
   });
 });