fix: migrate blocktank orders #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, testing... |
jvsena42
approved these changes
Jan 12, 2026
Member
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
Tested
- Migrate from RN to iOS ✅
- Transfer card displayed ✅
- Pending channel displayed ✅
- Channel confirmed ✅
- Lightning operations ✅
Haven't tested restore from mnemonic
Collaborator
|
For me the channel is opening after migration, but only after closing and re-opening the app. (Perhaps some UI refresh thing missing?) Screen.Recording.2026-01-12.at.10.45.08.movNote, also worked in the restore mnemonic (yet channel opened only after restarting the app). |
Member
For me, the migration worked without need to restart the app but I need it on restore flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match synonymdev/bitkit-android#593 (same testing instructions)