chore: fix all warnings and code cleanup #594
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitignore # README.md # app/src/main/java/to/bitkit/services/LightningService.kt
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| val network = Network.valueOf(BuildConfig.NETWORK) | ||
| val locales = BuildConfig.LOCALES.split(",") | ||
| val walletSyncIntervalSecs = 10_uL // TODO review | ||
| val walletSyncIntervalSecs = 10_uL |
Check warning
Code scanning / detekt
Usage of `vals` that can be `const val` detected. Warning
| Network.TESTNET -> ElectrumServers.TESTNET | ||
| Network.BITCOIN -> ElectrumServers.BITCOIN | ||
| else -> TODO("${network.name} network not implemented") | ||
| else -> throw Error("${network.name} network not implemented") |
Check warning
Code scanning / detekt
The thrown exception is too generic. Prefer throwing project specific exceptions to handle error cases. Warning
| import androidx.compose.foundation.rememberScrollState | ||
| import androidx.compose.foundation.verticalScroll | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.Stable |
Check warning
Code scanning / detekt
Detects unused imports Warning
| import androidx.compose.ui.geometry.Offset | ||
| import androidx.compose.ui.graphics.Color | ||
| import androidx.compose.ui.graphics.PathEffect | ||
| import androidx.compose.ui.res.stringResource |
Check warning
Code scanning / detekt
Detects unused imports Warning
| import androidx.compose.ui.res.stringResource | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import androidx.compose.ui.unit.dp | ||
| import to.bitkit.R |
Check warning
Code scanning / detekt
Detects unused imports Warning
ovitrif
changed the title
ovitrif
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Description
The PR addresses multiple code quality improvements and new features:
Localization
Features
Refactoring
Cleanup
Preview
N/A - Primarily code quality and localization changes
QA Notes
1. Localization
2. Boost Fee Estimates
3. Weather Widget
4. Regression Testing