Avoid refreshing token each request #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shughes-uk
commented
Nov 13, 2024
singhals
reviewed
Nov 13, 2024
Comment on lines
+70
to
71
| if not self.cached_token.is_access_token_valid: | ||
| raise TryAgain() |
Contributor
There was a problem hiding this comment.
Does the code ever reach this block?
Contributor
Author
There was a problem hiding this comment.
Sure after a status code not in the "retry status codes" list. It'll retry anyway 🤷♀️ . Basically the same as current behavior.
singhals
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
please add a few lines to give the reviewer context on the changes
Checklist
Before formally opening this PR, please adhere to the following standards:
Related Jira Ticket (add id)
Add any relevant testing examples or screenshots.