This repository is currently being migrated. It's locked while the migration is in progress.
Prod 2800 update termination reason codes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaymanWilliams
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
shughes-uk
approved these changes
Feb 15, 2025
gorskysd
approved these changes
Feb 15, 2025
CaymanWilliams
had a problem deploying
to
release
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The diff here is misleading, check out this diff instead. This is a direct comparison to the current upstream repo and makes it much easier to see all the cumulative changes we've made to our fork. This PR adds the missing TerminationReasonCode and also merges in the current main and cleans up some merge weirdness that we had accumulated.
The tests that aren't running are old and should've been dropped from the workflow but they're maybe still in the branch protection rules (https://github.com/orgs/community/discussions/139960) but I'm not able to follow the instructions to remove them, because of permissions probably. It looks like they won't block me from merging though, I remember we had a similar problem last time