Catching known errors when opening/closing files#9
Open
gohar94 wants to merge 1 commit intosymonsoft:masterfrom
Open
Catching known errors when opening/closing files#9gohar94 wants to merge 1 commit intosymonsoft:masterfrom
gohar94 wants to merge 1 commit intosymonsoft:masterfrom
Conversation
yagelsyf
approved these changes
Jun 25, 2022
| os.unlink(self._filepath) | ||
| try: | ||
| os.unlink(self._filepath) | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
Good change that I want to add too.
In rare cases that happen from time to time, its happen.
There was a problem hiding this comment.
I explained why this wouldn't work in #7 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

On Windows, when opening a file which is held by another process,
opencall throws an exception (which is expected) - putting that intry/except.On Linux, when closing a file that might have been closed by another process,
unlinkcall throws an exception (which is expecting) - putting that intry/except.