Skip to content

portalocker major release breaks ilock#6

Open
ayhun wants to merge 1 commit intosymonsoft:masterfrom
ayhun:patch-1
Open

portalocker major release breaks ilock#6
ayhun wants to merge 1 commit intosymonsoft:masterfrom
ayhun:patch-1

Conversation

@ayhun
Copy link

@ayhun ayhun commented Aug 4, 2020

Release of version 2.0 of portalocker https://pypi.org/project/portalocker/#history breaks iLock in python 2. A condition to use earlier versions of portalocker is necessary until version 2.0 is supported by ilock. Example exception caused by the portalocker release is available below:

2020-08-04 01:51:03,146 - Thread-7driver - ERROR: Unexpected Python Exception Occurred:
Traceback (most recent call last):
File "/home/pipelines/result_aggregation/driver.py", line 45, in
from package.app import *
File "/home/pipelines/result_aggregation/package/app.py", line 8, in
from ilock import ILock
File "/usr/bin/anaconda/lib/python2.7/site-packages/ilock/init.py", line 8, in
import portalocker
File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/init.py", line 5, in
from . import utils
File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/utils.py", line 290
def init(self, maximum: int, name: str = 'bounded_semaphore',
^
SyntaxError: invalid syntax

Release of version 2.0 of portalocker https://pypi.org/project/portalocker/#history breaks iLock. A condition to use earlier versions of portalocker is necessary. Example exception caused by the portalocker release is available below:

2020-08-04 01:51:03,146 - Thread-7driver - ERROR: Unexpected Python Exception Occurred:
Traceback (most recent call last):
  File "/home/pipelines/result_aggregation/driver.py", line 45, in <module>
    from package.app import *
  File "/home/pipelines/result_aggregation/package/app.py", line 8, in <module>
    from ilock import ILock
  File "/usr/bin/anaconda/lib/python2.7/site-packages/ilock/__init__.py", line 8, in <module>
    import portalocker
  File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/__init__.py", line 5, in <module>
    from . import utils
  File "/usr/bin/anaconda/lib/python2.7/site-packages/portalocker/utils.py", line 290
    def __init__(self, maximum: int, name: str = 'bounded_semaphore',
                              ^
SyntaxError: invalid syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments