remove privkey attribute from mp_obj_keypair_t#45
Open
scgbckbone wants to merge 1 commit intoswitck:masterfrom
Open
remove privkey attribute from mp_obj_keypair_t#45scgbckbone wants to merge 1 commit intoswitck:masterfrom
mp_obj_keypair_t#45scgbckbone wants to merge 1 commit intoswitck:masterfrom
Conversation
Contributor
scgbckbone
commented
Jan 12, 2026
scgbckbone
commented
- it was wasting 32 bytes for every keypair object
- private key is part of keypair struct (first 32 bytes), getting privkey from keypair is simple memcpy https://github.com/bitcoin-core/secp256k1/blob/master/src/modules/extrakeys/main_impl.h#L214-L222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.