Skip to content

Conversation

@rodepanda7
Copy link
Contributor

Closes #398 .

Summary

There was a small bug in the logic of displaying the correct registration info
If you cancel your registration, you won't be registered for the event anymore. I changed an or to an and. If we keep the 'or', the following message will be displayed if you cancelled your registration after the deadline, instead of the message we would like to display: 'Registration is not possible anymore. '

I also added the field registrationStatus to Event, so we can display the same message as the website

How to test

  1. Go to the event mooi test event
  2. Register for the event
  3. Change registration deadline
  4. Deregister for the event and you should get the message in the app: "Your registration is cancelled after the deadline and you will pay a fine of €10,00."

@rodepanda7 rodepanda7 self-assigned this Apr 23, 2025
@JAicewizard
Copy link
Contributor

Can you undo the changes to pubspec?

@JAicewizard
Copy link
Contributor

@rodepanda7

@JAicewizard
Copy link
Contributor

It has been a while, are you going to be at technicie next week? Maybe explain the changes to me again, and then I can maybe explain how to make tests. (The logic behind the event message is quite complicated, a test might be a good idea in general)

JAicewizard
JAicewizard previously approved these changes Nov 19, 2025
@rodepanda7 rodepanda7 dismissed JAicewizard’s stale review November 19, 2025 19:16

The merge-base changed after approval.

@JAicewizard JAicewizard merged commit 0b73b3d into master Nov 19, 2025
3 of 5 checks passed
@JAicewizard JAicewizard deleted the cancellation-status branch November 19, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancellation status messages for registrations

3 participants