Open
Conversation
ryanplusplus
commented
Nov 10, 2025
Comment on lines
+59
to
+61
| "dependencies": { | ||
| "@napi-rs/cli": "^3.2.0" | ||
| }, |
Author
There was a problem hiding this comment.
If this is listed as a dev dependency, it's not available for use by the install script.
ryanplusplus
force-pushed
the
auto-install
branch
from
30ebec5 to
e4659db
Compare
ryanplusplus
commented
Nov 10, 2025
Comment on lines
+29
to
+30
| "cargo.toml", | ||
| "src/*" |
Author
There was a problem hiding this comment.
These need to be included or there's nothing to build during install
ryanplusplus
commented
Nov 10, 2025
| "format:prettier": "prettier . -w", | ||
| "format:toml": "taplo format", | ||
| "format:rs": "cargo fmt", | ||
| "install": "npm run build", |
Author
There was a problem hiding this comment.
This makes it build automatically when being installed
ryanplusplus
force-pushed
the
auto-install
branch
from
7b14c31 to
c30665d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.