Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
paywallWebviewLoad_timeout- this event was causing confusion due to it's naming, leading to it being deprecatedChecklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.ktlintin the main directory and fixed any issues.Greptile Summary
Deprecated the
paywallWebviewLoad_timeoutevent by removing its internal state representation and marking the public event class as deprecated. Timeout scenarios now emitPaywallWebviewLoadFailevents withWebviewError.Timeoutinstead of a separate timeout event.Key Changes:
PaywallWebviewLoad.State.Timeoutclass and its mapping logic@Deprecatedannotations toPaywallWebviewLoadTimeoutevent classesImpact:
The timeout scenario still functions correctly - when a paywall load times out, it now triggers a fail event rather than a distinct timeout event. This simplifies the event model while maintaining the same error handling behavior in
PaywallView.kt:316.Confidence Score: 5/5
Important Files Changed
State.Timeoutclass and its mapping logic fromPaywallWebviewLoadevent@Deprecatedannotation toPaywallWebviewLoadTimeoutevent classPaywallWebviewLoad.State.Timeoutevent handlingSequence Diagram
sequenceDiagram participant PV as PaywallView participant WV as WebView participant TE as TrackableSuperwallEvent participant SE as SuperwallEvent Note over PV,SE: Before: Timeout Event Flow PV->>PV: timeout detected PV->>TE: PaywallWebviewLoad(State.Timeout) TE->>SE: PaywallWebviewLoadTimeout SE-->>PV: timeout event tracked Note over PV,SE: After: Timeout Now Treated as Fail PV->>PV: timeout detected PV->>TE: PaywallWebviewLoad(State.Fail(WebviewError.Timeout)) TE->>SE: PaywallWebviewLoadFail SE-->>PV: fail event tracked