Investigate popular feed item duplication and time sensitivity #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: paolo <paolo@finwerk.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: paolo <paolo@finwerk.com>
Co-authored-by: paolo <paolo@finwerk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 'all-time' popular feed being time-sensitive and ensures different popular feeds return distinct top items.
The 'all-time' feed was inadvertently filtering by date due to an invalid
sincecalculation. Additionally, all popular feeds used the samecreated_at DESCordering for candidate selection, leading to significant overlap in top results. This PR updates the 'all-time' feed to consider total engagement signals and removes date filtering, while time-limited feeds retain recency-based ordering. Explicit sorting by score is also added for consistency.