Feature/distribution details

[0xSero]

PR:

Addresses: #19

What was done?

Created distribution page with the following:

Addresses, amount and pool percentage

Changes made:

• Had to add: onCellClick={(row, e) => e.stopPropagation()} to dataGrid as per: > > > > datagrid version 5.17.8 still has the error steps to reproduce mui/mui-x#7943
• Added a new query to get distribution details for index update event:

export const getDistributionDetails = (distributionId: string) => `{
  indexUpdatedEvent(id: "${distributionId}") {
    index {
      indexId
      indexValue
      totalAmountDistributedUntilUpdatedAt
      totalSubscriptionsWithUnits
      totalUnits
      subscriptions(where: {units_not: "0"}) {
        units
        totalAmountReceivedUntilUpdatedAt
        subscriber {
          id
        }
      }
      token {
        id
      }
    }
    timestamp
    publisher
    totalUnitsApproved
    totalUnitsPending
    newIndexValue
    oldIndexValue
  }
}`;

Event showcase:

2023-02-27.06-22-28.mp4

Closes: #149

[vercel]

@Seroxdesign is attempting to deploy a commit to the Superfluid Finance Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
superfluid-console	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 27, 2023 at 0:14AM (UTC)

[kasparkallas]

Hey! I'll take a look at this. Any pending questions or TODO-s?

[0xSero]

Hey! I'll take a look at this. Any pending questions or TODO-s?

Yes, I am quering the SF subgraph as follows:

 useEffect(() => {
    if (!distributionId) return;
    const fetchData = async () => {
      await fetch(baseUrl, {
        method: "POST",
        headers: new Headers({
          "Content-Type": "application/json",
        }),
        body: JSON.stringify({
          query: `${getDistributionDetails(distributionId)}`,
        }),
      })
        .then((res) => res.json())
        .then((res) => {
          const distribution = res.data.indexUpdatedEvent;
          if (distribution) {
            handleSetDistributionDetails(distribution);
          }
        });
    };
    fetchData();
  }, [distributionId]);

Unfortunately I couldn't find docs or examples on how to use sfSubgraph directly.

• I forgot to add an export, just pushed a fix so deploy should work now, can you re-authorise? @kasparkallas

[elvijsTDL]

@Seroxdesign I come once again to ask for bug fixes 😄

Check this one out: https://superfluid-console-git-fork-hunters-w-7430a0-superfluid-finance.vercel.app/matic/distributions/IndexUpdated-0xd572b6c175fc462f48c2885d13ada0cd8dc7cb1a1fa7c0c0d11c0ede98ca2658-611

The total amount does not add up to the subscribed amount

Also it seems like the feature does not show the total units at the point of distribution and the subscribers correctly , that looks like a stream to ricochet and if i'm not mistaken, the units there are updated depending on the flow rate, maybe just a coinsidence, but seems very unlikely that the units and subscribers have not changed in months , especially seeing that the total amount is wrong, I feel like it fetches 1 state and shows it in all distribution details pages

Screen.Recording.2023-02-28.at.12.01.06.mov

[0xSero]

@Seroxdesign I come once again to ask for bug fixes 😄

Check this one out: https://superfluid-console-git-fork-hunters-w-7430a0-superfluid-finance.vercel.app/matic/distributions/IndexUpdated-0xd572b6c175fc462f48c2885d13ada0cd8dc7cb1a1fa7c0c0d11c0ede98ca2658-611

The total amount does not add up to the subscribed amount

Also it seems like the feature does not show the total units at the point of distribution and the subscribers correctly , that looks like a stream to ricochet and if i'm not mistaken, the units there are updated depending on the flow rate, maybe just a coinsidence, but seems very unlikely that the units and subscribers have not changed in months , especially seeing that the total amount is wrong, I feel like it fetches 1 state and shows it in all distribution details pages

Screen.Recording.2023-02-28.at.12.01.06.mov

Understood will investigate this further and fix it thanks for taking the time to test and review 🙏

[kasparkallas]

These units might not be the same as they were at the time of the distribution. These are the latest units.

[kasparkallas]

Understood will investigate this further and fix it thanks for taking the time to test and review

Be careful, might be a rabbit hole.

Sorry, I haven't been quick to review this. It's a bit more tricky... I skimmed over it yesterday and it made my wheels turn.

I'm thinking open-minded and it might be the case that the best way to solve this page is:

1. Get the distribution event (with the block number it happened at)
2. Query the subscriptions for that index at that block number.
3. Loop and match in the UI

Example of the query at 2:

query MyQuery {
  indexSubscriptions(block: {number: $BLOCK_NUMBER}, where: {index: $INDEX_ID}) {
    units
  }
}

• The SDK supports querying by block number.
• The Subgraph has history of every entity for every block number. It's like that to handle re-orgs and time-travel queries like this.

[0xSero]

As per @kasparkallas the bounty can be marked as complete, there was an issue I couldn't address and Kaspar will be taking a look at it, if anything comes up that i can help with ping me.