Skip to content

fix: correctly pass table info when deriving inline run properties (SD-1865)#2007

Open
luccas-harbour wants to merge 3 commits intomainfrom
luccas/sd-1865-bug-document-text-displays-incorrect-formatting
Open

fix: correctly pass table info when deriving inline run properties (SD-1865)#2007
luccas-harbour wants to merge 3 commits intomainfrom
luccas/sd-1865-bug-document-text-displays-incorrect-formatting

Conversation

@luccas-harbour
Copy link
Contributor

@luccas-harbour luccas-harbour commented Feb 12, 2026

  • There was a bug during the computation of inline run properties where a parameter with information about a run's parent table wasn't passed. This made subsequent parameters get shifted, causing incorrect calculations for some documents.
  • This was fixed and table information is now being extracted and used for computing properties.
  • There was also an issue where table/list information was not correctly passed when splitting a run. This was also fixed.
  • And finally, some type definitions for the style resolution functions were outdated. These were fixed.

@linear
Copy link

linear bot commented Feb 12, 2026

@luccas-harbour luccas-harbour changed the title fix: pass table info when deriving inline run properties fix: correctly pass table info when deriving inline run properties (SD-1865) Feb 12, 2026
@luccas-harbour luccas-harbour marked this pull request as ready for review February 12, 2026 13:58
@luccas-harbour luccas-harbour marked this pull request as draft February 12, 2026 14:02
@luccas-harbour luccas-harbour force-pushed the luccas/sd-1865-bug-document-text-displays-incorrect-formatting branch 2 times, most recently from b8989ea to 6557a44 Compare February 12, 2026 16:03
@luccas-harbour luccas-harbour marked this pull request as ready for review February 12, 2026 16:13
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6557a4498c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@luccas-harbour luccas-harbour force-pushed the luccas/sd-1865-bug-document-text-displays-incorrect-formatting branch from 6557a44 to f40a171 Compare February 12, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant