feat: enabled telemetry by default and added documentation #2001
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ac924f34b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ocking in smoke tests
…ture - Introduced a new telemetry resource documentation in `resources/telemetry.mdx` detailing the telemetry data collection process and configuration options. - Updated `docs.json` to include the new telemetry documentation in the resources section. - Added a `DocCounter` component in `doc-counter.jsx` to track and display unique document counts during usage. - Enhanced the `SuperConverter` class to utilize SHA-256 for generating document identifiers, improving hash stability and security.
andrii-harbour
changed the title
- Updated the visual harness initialization to set telemetry.enabled to false, ensuring telemetry is disabled during visual tests.
harbournick
left a comment
harbournick
left a comment
There was a problem hiding this comment.
feels a bit risky to merge this and go direct to stable tbh with the super converter lib changes. if hash changes are necessary we should keep it in main longer IMO and we need test coverage for the new fns
| * @returns {string} Hash identifier in format "HASH-XXXXXXXX" | ||
| */ | ||
| #generateIdentifierHash() { | ||
| async #generateIdentifierHash() { |
There was a problem hiding this comment.
why were these changes necessary? seems a bit risky since the testing days have been using the previous lib and system. Is there a strong reason for removing crc lib and replacing with this approach?
2 participants
No description provided.