bug: list items are cut off on left edge inside table (SD-1836) by luccas-harbour · Pull Request #1996 · superdoc-dev/superdoc

luccas-harbour · 2026-02-11T17:54:27Z

Lists markers inside tables were being rendered incorrectly, causing them to be cut off in some situations
A fix was made to implement the same rendering logic as when lists show up as top-level elements
A visual test document was uploaded to the corpus

Before:

After:

linear · 2026-02-11T17:54:31Z

SD-1836 Bug: list items are cut off on left edge inside table

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b0e21929e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-11T18:15:58Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

-  // Align text start to the marker start position (gutter spacing comes from marker padding)
-  lineEl.style.paddingLeft = `${markerStartPos}px`;
+  // Position marker within the container
+  if (['center', 'right'].includes(markerJustification)) {


Apply anchor offset for left-justified table list markers

This block only applies marker/text offset logic for center and right, so the default left case never uses anchorPoint to position the first line. In table list paragraphs with non-zero list indents/hanging indents, the marker and following text are laid out from the cell edge instead of the computed list anchor, which shifts content left and can still clip near the table border.

Useful? React with 👍 / 👎.

left-justified markers start at x=0 in the container -- anchorPoint offset is not applied. continuation lines get paddingLeft = indentLeftPx, so first-line text won't align with body text.

maybe lineEl.paddingLeft = anchorPoint would fix this (like in renderer.ts)

chatgpt-codex-connector · 2026-02-11T18:15:58Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

              markerMeasure,
              indentLeftPx,
+              hangingIndentPx,
+              firstLineIndentPx,
            });


Pass paragraph tab stops when rendering table list markers

renderListMarker now computes tab spacing from tabsPx, but this call site never forwards wordLayout?.tabsPx, so explicit tab stops from the paragraph are dropped for list items inside table cells. Documents that use custom list tab stops will therefore fall back to default/implicit tab widths and render marker-to-text spacing incorrectly.

Useful? React with 👍 / 👎.

caio-pizzol

added a few comments!

also worth mentioning - we might need to upload the sample/test file to R2 so we can run visual testing against it

caio-pizzol · 2026-02-11T19:01:46Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

 * This is applied when a gutter width is not explicitly provided in the marker layout.
 * The 8px default matches Microsoft Word's standard list marker spacing.
 */
 const LIST_MARKER_GAP = 8;


LIST_MARKER_GAP is dead code after the rewrite -- no longer referenced.

caio-pizzol · 2026-02-11T19:02:43Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

 * Word layout information for paragraph list markers.
 * Contains positioning, styling, and rendering details for list markers (bullets/numbers).
 */
 type WordLayoutMarker = {


local WordLayoutMarker/WordLayoutInfo duplicate types in @superdoc/contracts.

maybe import from contracts to stay in sync?

caio-pizzol · 2026-02-11T19:04:07Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

+    markerStartPos = anchorPoint - markerTextWidth;
+    currentPos = anchorPoint;
+  } else {
+    markerStartPos = anchorPoint - markerTextWidth / 2;


center justification computes left = anchorPoint - markerTextWidth (half-width subtracted twice), identical to right-justified positioning. renderer.ts line 2305 has the same math -- intentional, or pre-existing bug?

caio-pizzol · 2026-02-11T19:05:23Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

-  // Align text start to the marker start position (gutter spacing comes from marker padding)
-  lineEl.style.paddingLeft = `${markerStartPos}px`;
+  // Position marker within the container
+  if (['center', 'right'].includes(markerJustification)) {


left-justified markers start at x=0 in the container -- anchorPoint offset is not applied. continuation lines get paddingLeft = indentLeftPx, so first-line text won't align with body text.

maybe lineEl.paddingLeft = anchorPoint would fix this (like in renderer.ts)

caio-pizzol · 2026-02-11T19:06:14Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

-  lineEl.style.paddingLeft = `${markerStartPos}px`;
+  // Position marker within the container
+  if (['center', 'right'].includes(markerJustification)) {
+    lineEl.style.paddingLeft = parseFloat(lineEl.style.paddingLeft || '0') + currentPos + listTabWidth + 'px';


paddingLeft includes listTabWidth, but the separator element (width listTabWidth) is a sibling outside lineEl -- tab width counted twice. text shifts one tab-width too far right.

should we drop listTabWidth from the padding or move the separator inside lineEl?

caio-pizzol · 2026-02-11T19:06:48Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

        // Create wrapper for this paragraph's SDT metadata
        // Use absolute positioning within the content container to stack blocks vertically
        const paraWrapper = doc.createElement('div');
+        paraWrapper.classList.add('superdoc-table-paragraph');


superdoc-table-paragraph class added but no CSS or JS references it.

caio-pizzol · 2026-02-11T19:07:32Z

packages/layout-engine/painters/dom/src/table/renderTableCell.ts

             * This creates a container with the marker positioned absolutely
             * and the line content positioned with appropriate padding.
             */
            const lineContainer = renderListMarker({


tabsPx is accepted but never passed -- explicit tab stops from the document will be ignored in table cells, falling back to default 48px intervals.

should we add tabsPx to WordLayoutInfo and pass it here?

caio-pizzol · 2026-02-11T19:08:01Z

packages/layout-engine/painters/dom/src/utils/marker-helpers.ts

@@ -0,0 +1,60 @@
+/**


extraction is justified (2 call sites) but the export has no JSDoc.

let's add a one-liner describing what it does.

caio-pizzol · 2026-02-11T19:08:31Z

packages/layout-engine/painters/dom/src/utils/marker-helpers.ts

+): number => {
+  const nextDefaultTabStop = currentPos + DEFAULT_TAB_INTERVAL_PX - (currentPos % DEFAULT_TAB_INTERVAL_PX);
+  let tabWidth: number;
+  if ((justification ?? 'left') === 'left') {


(justification ?? 'left') -- param is string, never null or undefined. redudant?

caio-pizzol · 2026-02-11T19:08:57Z

packages/layout-engine/painters/dom/src/utils/marker-helpers.ts

+      explicitTabs.push(implicitTabPos);
+      // Sort tab stops to maintain order
+      explicitTabs.sort((a, b) => {
+        if (typeof a === 'number' && typeof b === 'number') {


typeof guards in sort comparator looks like dead code -- the array is number[].

Luccas Correa added 2 commits February 11, 2026 15:02

refactor: extract helper for computing marker tab width

91938a5

fix: correctly compute list markers inside tables

8b0e219

luccas-harbour force-pushed the luccas/sd-1836-bug-list-items-are-cut-off-on-left-edge-inside-table branch from 7f70b78 to 8b0e219 Compare February 11, 2026 18:02

caio-pizzol assigned luccas-harbour Feb 11, 2026

luccas-harbour marked this pull request as ready for review February 11, 2026 18:11

luccas-harbour requested review from VladaHarbour, caio-pizzol, harbournick and tupizz February 11, 2026 18:11

tupizz approved these changes Feb 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 11, 2026

View reviewed changes

caio-pizzol reviewed Feb 11, 2026

View reviewed changes

Conversation

luccas-harbour commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Feb 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

caio-pizzol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

luccas-harbour commented Feb 11, 2026 •

edited

Loading