Skip to content

fix: handle semicolon font fallback separators #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattConnHarbour wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: handle semicolon font fallback separators #1991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion shared/font-utils/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,15 @@ export function mapWordFamilyFallback(wordFamily) {
*/
export function toCssFontFamily(fontName, options = {}) {
if (!fontName || typeof fontName !== 'string') return fontName;
const trimmed = fontName.trim();
let trimmed = fontName.trim();
// replace semicolon font fallback separators
if (trimmed.includes(';')) {
Copy link
Contributor

@caio-pizzol caio-pizzol Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once semicolons become commas, the comma check on line 202 returns early -- no sans-serif fallback gets added.

works today because the import path already adds one, but if this function gets called with raw "Liberation Sans;Arial" it'll be missing a generic fallback.

Copy link
Contributor

@caio-pizzol caio-pizzol Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also.. needs tests for semicolon inputs -- the early return on line 202 skipping fallbacks is easy to miss without one. toCssFontFamily("Liberation Sans;Arial") and toCssFontFamily("Foo;Bar", { wordFamily: 'swiss' }) would cover it.

trimmed = trimmed
.split(';')
.map((part) => part.trim())
Comment on lines +195 to +198
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not split semicolons inside quoted font names

The new semicolon normalization splits on every ; without considering quotes, so a literal family like "Foo;Bar" is rewritten to "Foo, Bar" before the early comma return. That changes the actual font identifier and causes incorrect font matching for any document that uses quoted font names containing semicolons, which this function previously preserved.

Useful? React with 👍 / 👎.

Copy link
Contributor

@caio-pizzol caio-pizzol Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattConnHarbour check and add a response if applicable/or not

.filter(Boolean)
.join(', ');
}
if (!trimmed || trimmed.includes(',')) return trimmed;

const { fallback, wordFamily } = options;
Expand Down
Loading