-
Notifications
You must be signed in to change notification settings - Fork 66
fix: disable context menu in web view mode (SD-1823) #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: disable context menu in web view mode (SD-1823) #1989
Conversation
luccas-harbour
commented
Feb 10, 2026
- On mobile, when the "web" view mode is active, long pressing a word in the editor would trigger the context menu, preventing the user from being able to select text.
- A change was made so that the context menu is disabled in "web" mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cf7271b1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one!
should we add interaction stories for this one?
adding @andrii-harbour here since this can impact eSign
|
haven't looked at the code yet, but definitely want to try this SD version with eSign. Will check today |
7715b1f to
5a1c2e1
Compare
caio-pizzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!