fix: normalize bookmarks in tables #1892
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f6ac31816
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Outdated
Show resolved
Hide resolved
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
looks good overall! just a minor comment
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.test.js
Show resolved
Hide resolved
… sd-1681_block-id-crash
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@VladaHarbour just a few more comments around ECMA spec - worth double checking before merging
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Outdated
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Show resolved
Hide resolved
packages/super-editor/src/core/super-converter/v2/importer/docxImporter.js
Show resolved
Hide resolved
|
@caio-pizzol please let me know If I have to do something with the last spec review. https://ooxml.dev/ page 900 tells that colFirst/colLast are valid attributes for bookmarkStart |
4 participants
No description provided.