Skip to content

Done Hashing-2#2140

Open
Sreeja-99 wants to merge 3 commits intosuper30admin:masterfrom
Sreeja-99:master
Open

Done Hashing-2#2140
Sreeja-99 wants to merge 3 commits intosuper30admin:masterfrom
Sreeja-99:master

Conversation

@Sreeja-99
Copy link

No description provided.

Implement subarray sum function using a hashmap to count occurrences of sums.
Implement solution to find longest palindrome length.
Implement solution to find maximum length of contiguous subarray with equal number of 0's and 1's using prefix sum and hashmap.
@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a good understanding of the problems and their solutions.
    • The code is clean, well-commented, and easy to follow.
    • The student correctly identifies and implements the optimal time and space complexity for each problem.
  • Areas for Improvement:
    • While the comments are helpful, they could be more concise. For example, in Leetcode_560.java, the comment "As they are asking subarray sum, have a variable and maintain sum in it at every index" could be simplified to "Track cumulative sum to find subarrays summing to k."
    • The variable names could be more descriptive. For example, in Leetcode_560.java, count could be renamed to result to match the reference solution's naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants