Skip to content

Done with Hashing-2#2138

Open
Mukul585 wants to merge 1 commit intosuper30admin:masterfrom
Mukul585:master
Open

Done with Hashing-2#2138
Mukul585 wants to merge 1 commit intosuper30admin:masterfrom
Mukul585:master

Conversation

@Mukul585
Copy link

@Mukul585 Mukul585 commented Jan 3, 2026

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • All solutions are correct and efficient, with optimal time and space complexity.
    • The logic is clear and well-implemented, demonstrating a good understanding of the problems.
    • Variable names are descriptive, making the code easy to read.
  • Areas for Improvement:

    • Improve code formatting for consistency (e.g., spacing around operators and braces).
    • In Problem1.java, the comment "//if map conatins y (for ex y = x-z) then increase the count as per frequency" could be clearer. Consider rephrasing to better explain the logic.
    • In Problem3.java, the comment "//If set is not empty, increase the count variable by 1" is placed outside the loop but is part of the loop's logic. It should be moved inside the loop or clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants