Skip to content

Completed Hashing -2#2137

Open
kkhevna9252 wants to merge 1 commit intosuper30admin:masterfrom
kkhevna9252:master
Open

Completed Hashing -2#2137
kkhevna9252 wants to merge 1 commit intosuper30admin:masterfrom
kkhevna9252:master

Conversation

@kkhevna9252
Copy link

No description provided.

@super30admin
Copy link
Owner

  • The student's solution is well-implemented and follows best practices. The logic is clear and concise, and the use of Kotlin's features like mutableMapOf and apply is appropriate.
  • One minor improvement could be to use nums.indices instead of 0..nums.size - 1 in the findMaxLength function for better readability and idiomatic Kotlin.
  • The comments in the code are helpful but could be slightly more detailed to explain the logic more thoroughly, especially for someone unfamiliar with the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants