Skip to content

Hashing-2#2134

Open
praxpk wants to merge 1 commit intosuper30admin:masterfrom
praxpk:master
Open

Hashing-2#2134
praxpk wants to merge 1 commit intosuper30admin:masterfrom
praxpk:master

Conversation

@praxpk
Copy link

@praxpk praxpk commented Dec 31, 2025

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a strong understanding of hash-based solutions and efficiently applies them to solve the problems.
    • The code is clean, well-commented, and easy to follow.
    • The student correctly identifies and handles edge cases, such as when no subarray is found in contiguos_araay.py.
  • Areas for Improvement:
    • The file name contiguos_araay.py contains a typo ("araay" instead of "array"). Attention to detail in file naming is important for maintainability.
    • In subarray_sum_k.py, the condition if running_sum - k in sum_map could be combined with the subsequent update to sum_map to avoid redundant checks, though the current implementation is still correct.
    • The comments in subarray_sum_k.py could be slightly more detailed to explain why the initial sum_map is initialized with {0:1}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants