Skip to content

Graph-1-Complete#779

Open
PrasiddhShah wants to merge 1 commit intosuper30admin:masterfrom
PrasiddhShah:master
Open

Graph-1-Complete#779
PrasiddhShah wants to merge 1 commit intosuper30admin:masterfrom
PrasiddhShah:master

Conversation

@PrasiddhShah
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • The student has a good understanding of the problems and has implemented efficient solutions.
    • The code is clean, well-commented, and follows best practices.
    • The time and space complexity analyses are accurate.
  • Areas for Improvement:

    • For problem1.java, the comment mentions "topological sort," which is not entirely accurate. The solution uses indegree counting, which is a different concept. Clarifying this in the comments would be helpful.
    • For problem2.java, the comment could be more detailed about the BFS approach and why it's suitable for this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants