Skip to content

Completed Graph-1, 2 problems#772

Open
meetrpatels30 wants to merge 1 commit intosuper30admin:masterfrom
meetrpatels30:master
Open

Completed Graph-1, 2 problems#772
meetrpatels30 wants to merge 1 commit intosuper30admin:masterfrom
meetrpatels30:master

Conversation

@meetrpatels30
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Both solutions are correct and efficiently implemented.
    • The code is clean, well-commented, and easy to understand.
    • Time and space complexities are accurately analyzed and stated.
  • Areas for Improvement:
    • In "the-maze", consider using a more efficient data structure for the queue (e.g., a linked list or a double-ended queue) to avoid the O(n) shift operation, which can be costly for large queues.
    • In "find-the-town-judge", the comment "check for n-1, to exclude judge" could be clarified to explain why n-1 is the threshold (since the judge must be trusted by everyone else and trust no one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants