Skip to content

graph1 done#769

Open
desaiparam wants to merge 1 commit intosuper30admin:masterfrom
desaiparam:master
Open

graph1 done#769
desaiparam wants to merge 1 commit intosuper30admin:masterfrom
desaiparam:master

Conversation

@desaiparam
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • The student has a good understanding of the problems and has provided correct solutions.
    • The code is well-commented and easy to follow.
    • The time and space complexities are correctly analyzed and match the reference solutions.
  • Areas for Improvement:

    • For the town judge problem, the student could consider using a single array to track both in-degree and out-degree (e.g., incrementing for in-degree and decrementing for out-degree), which would reduce space usage slightly.
    • The ball in maze solution could benefit from a brief explanation of why BFS is chosen over DFS, as BFS is typically preferred for shortest path problems in unweighted graphs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants