Skip to content

Done Graph-1#760

Open
akhilsai25 wants to merge 2 commits intosuper30admin:masterfrom
akhilsai25:master
Open

Done Graph-1#760
akhilsai25 wants to merge 2 commits intosuper30admin:masterfrom
akhilsai25:master

Conversation

@akhilsai25
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Both solutions are correct and efficient, matching the expected time and space complexities.
    • The code is readable and follows good practices like using descriptive variable names and clear logic.
  • Areas for Improvement:
    • In Maze-1, consider using a constant (e.g., static final int VISITED = -1) instead of a magic number to mark visited cells for better maintainability.
    • In TownJudge, the comment could be more detailed to explain why the indegree approach works (i.e., the judge must have n-1 inward edges and 0 outward edges).
    • Ensure consistent indentation and spacing throughout the code for better readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants