fix: Add error recovery for TUS uploads with RustFS S3 backend#822
Open
Adityakk9031 wants to merge 1 commit intosupabase:masterfrom
Open
fix: Add error recovery for TUS uploads with RustFS S3 backend#822Adityakk9031 wants to merge 1 commit intosupabase:masterfrom
Adityakk9031 wants to merge 1 commit intosupabase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
TUS resumable uploads through Supabase Studio return HTTP 500/409 errors when using RustFS as the S3-compatible backend, despite files uploading successfully.
Error messages:
Root cause: RustFS implementation of
CompleteMultipartUploadrejects the parts list or returns an error response even though the file is successfully persisted to storage. This prevents theonUploadFinishhook from executing, leaving the file metadata missing from the Postgres database.Solution
Created a
CustomS3Storethat extends@tus/s3-storewith graceful error handling:finish()method to catchCompleteMultipartUploaderrorsHeadObjectrequest to verify if the file actually existsThis allows uploads to complete successfully even when RustFS returns confusing error responses.
Changes
-Added:
src/http/routes/tus/custom-s3-store.ts- Custom S3Store with error recoverysrc/http/routes/tus/index.ts- ReplacedS3StorewithCustomS3StoreRelated Issue
Fixes #41578