Skip to content

Comments

fix: improve error message for insufficient privilege#590

Open
fenos wants to merge 1 commit intomasterfrom
fix/improve-db-errors
Open

fix: improve error message for insufficient privilege#590
fenos wants to merge 1 commit intomasterfrom
fix/improve-db-errors

Conversation

@fenos
Copy link
Contributor

@fenos fenos commented Nov 20, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Make the error message more descriptive when insufficient privileges error is thrown by postgres

@fenos fenos force-pushed the fix/improve-db-errors branch from 7ae0ff6 to 4f851dc Compare November 20, 2024 12:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11933728752

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 77.857%

Totals Coverage Status
Change from base Build 11891699039: -0.004%
Covered Lines: 13928
Relevant Lines: 17748

💛 - Coveralls

@soedirgo
Copy link
Member

soedirgo commented Feb 3, 2025

@fenos is this ready to be merged?

@soedirgo
Copy link
Member

@supabase/storage ?

@ferhatelmas ferhatelmas force-pushed the fix/improve-db-errors branch from 4f851dc to 6b0d03c Compare February 20, 2026 08:43
@ferhatelmas ferhatelmas requested a review from a team as a code owner February 20, 2026 08:43
@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved clarity of database permission error messages for enhanced user feedback and consistency.

Walkthrough

The pull request updates error message handling for PostgreSQL permission errors. In the database error mapping layer, the error code 42501 (permission denied) now returns a more generic error message "Database error: insufficient privilege" instead of the PostgreSQL-specific "new row violates row-level security policy". The error type remains AccessDenied. Corresponding test expectations in both unit tests and integration test YAML files are updated to reflect this new message.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants