Add state parameter support for server-side OAuth CSRF protection#116
Open
mazensakr05 wants to merge 2 commits intosupabase-community:masterfrom
Open
Add state parameter support for server-side OAuth CSRF protection#116mazensakr05 wants to merge 2 commits intosupabase-community:masterfrom
mazensakr05 wants to merge 2 commits intosupabase-community:masterfrom
Conversation
- Add optional State property to SignInOptions for custom state values - Add State property to ProviderAuthState to return state to developer - Auto-generate state using GenerateNonce() when not provided by developer - Add state parameter to OAuth authorization URL query string - Implements CSRF protection per OAuth2 RFC 6749 Section 10.12 This allows developers to: 1. Provide custom state for server-side CSRF validation 2. Use auto-generated state for convenience 3. Store and validate state in OAuth callbacks Tested with ASP.NET Core application - state parameter now appears in OAuth URLs and is accessible via ProviderAuthState.State property. Fixes supabase-community/supabase-csharp#222
Updated the `SignUpWithEmail` method to support a new `CaptchaToken` property in `SignUpOptions`, enabling captcha verification during sign-up. Removed the `redirect_to` query parameter logic for cleaner implementation. Added the `CaptchaToken` property to the `SignUpOptions` class. Introduced a new test method, `SignUpUserWithCaptchaToken`, to validate the functionality of signing up with a captcha token.
Author
|
I've also added captcha token support (from issue #213) in this PR. Changes: Added optional CaptchaToken property to SignUpOptions Wired it to the auth API request as captcha_token field Added test coverage Non-breaking, additive change Both features follow the same pattern (optional parameters for auth flows), so I grouped them together. Let me know if you'd prefer these as separate PRs. |
Collaborator
|
FYI there isn't an active maintainer for this repo, suggest reaching out to Supabase support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows developers to:
Tested with ASP.NET Core application - state parameter now appears in OAuth URLs and is accessible via ProviderAuthState.State property.
Fixes supabase-community/supabase-csharp#222
What kind of change does this PR introduce?
Feature - Adds state parameter support for OAuth CSRF protection
What is the current behavior?
Currently, the SDK only supports PKCE flow for OAuth authentication, which protects against authorization code interception but does NOT protect against CSRF attacks in server-side OAuth flows.
The
SignInOptionsclass lacks aStateproperty, andProviderAuthStatedoes not return a state value. This makes it impossible for server-side ASP.NET Core applications to implement CSRF protection as recommended by OAuth2 RFC 6749 Section 10.12.Related issue: supabase-community/supabase-csharp#222
What is the new behavior?
This PR adds support for the OAuth2
stateparameter:Changes Made
Stateproperty toSignInOptionsStateproperty toProviderAuthStatereturn valueHelpers.GetUrlForProvider()to use developer-provided state or auto-generate usingGenerateNonce()Usage Examples
Server-side with CSRF protection: