Open
Conversation
…for session expiration.
Author
Are you saying this patch doesn't resolve the issue? |
|
I think this could solve #108 |
|
I tested this changes and, actually, it helps but it doesn't fully fix #108 I needed to make a change in I changed it so it checks if autorefresh is activated, and now it works fine, autorefresh the token everytime I open the app and the session has expired: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refresh token never expires. Don't need to check for session expiration when refreshing.
This fixes a bug making it impossible to recover a session after the client has been offline for longer than the expiry time of the access token.
What is the current behavior?
Can't use a refresh token beyond the expiry time of the access token.
What is the new behavior?
Client can now try to refresh the access token for as long as it holds the refresh token.