feature/SAUTHC-14 | Replace deprecated crypto usage #13

amrography · 2025-11-06T06:08:27Z

No description provided.

codecov · 2025-11-06T06:09:42Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.48%. Comparing base (6c40588) to head (d8d68a5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   48.78%   50.48%   +1.70%     
==========================================
  Files           2        2              
  Lines         205      208       +3     
  Branches       53       49       -4     
==========================================
+ Hits          100      105       +5     
  Misses        103      103              
+ Partials        2        0       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…t 19 compatibility - Updated TypeScript compiler options: - "target": "ES2020" - "module": "ESNext" - "outDir": "./dist" - Enabled esModuleInterop, strict mode, and proper module resolution - Ensures proper ESM output for Vite and React 19 projects - Keeps type declarations in "dist" folder

Copilot

Pull Request Overview

This PR replaces deprecated Node.js crypto usage with browser-compatible alternatives to support client-side authentication. The changes migrate from crypto and jsonwebtoken packages to jose, jwt-decode, and js-sha256, while also modernizing the TypeScript configuration.

Key Changes:

Replaced Node.js crypto module with js-sha256 for hashing and custom random string generation
Migrated from jsonwebtoken to jose and jwt-decode for JWT operations
Updated TypeScript target to ES2020 and module system to ESNext

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.

File	Description
package.json	Removed deprecated `crypto` and `jsonwebtoken` dependencies; added `jose`, `js-sha256`, and `jwt-decode` as replacements; updated TypeScript to v5.9.3
tsconfig.json	Modernized compiler options with ES2020 target, ESNext modules, and additional strict mode settings for better type safety
src/AuthManager.ts	Implemented browser-compatible crypto alternatives: custom random string generator for PKCE, `js-sha256` for hashing, and split JWT operations between `jose` (verify) and `jwt-decode` (decode); updated return types to allow null values
package-lock.json	Dependency tree updates reflecting the package changes with removal of jsonwebtoken-related dependencies and addition of new crypto libraries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/AuthManager.ts

…e generation

…mize build process

Copilot

Pull Request Overview

Copilot reviewed 7 out of 10 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-18T20:59:23Z

tests/AuthManager.test.ts

-      expect(localStorage.setItem).toHaveBeenCalledWith('codeChallenge', expect.anything());
-    });
-
+    const loginCallback = vi.fn()


Missing semicolon after vi.fn(). This is inconsistent with other similar lines in the file (e.g., lines 33, 44, 106) and standard JavaScript/TypeScript conventions.

Suggested change

const loginCallback = vi.fn()

const loginCallback = vi.fn();

Copilot · 2025-11-18T20:59:23Z

tests/AuthManager.test.ts

+
+  describe('AuthManager Tests isolated ', () => {
+    it("doesn't refresh access token when its not expired", async () => {
+      const stateChange = vi.fn()


Missing semicolon after vi.fn(). This is inconsistent with other similar lines in the file and standard JavaScript/TypeScript conventions.

Suggested change

const stateChange = vi.fn()

const stateChange = vi.fn();

Copilot · 2025-11-18T20:59:23Z

tests/AuthManager.test.ts

+  it('throws an error when no refresh token is found', async () => {
+    localStorage.removeItem('refresh_token');
+
+    const loginCallback = vi.fn()


Missing semicolon after vi.fn(). This is inconsistent with other similar lines in the file and standard JavaScript/TypeScript conventions.

Suggested change

const loginCallback = vi.fn()

const loginCallback = vi.fn();

Copilot · 2025-11-18T20:59:24Z

tests/AuthManager.test.ts


-
-
+    const loginCallback = vi.fn()


Missing semicolon after vi.fn(). This is inconsistent with other similar lines in the file and standard JavaScript/TypeScript conventions.

Copilot · 2025-11-18T20:59:24Z

tests/AuthManager.test.ts

+  it('logs out and clears local storage', async () => {
+    mock.onPost('http://auth-server.com/auth/logout').reply(200);
+
+    const loginCallback = vi.fn()


Missing semicolon after vi.fn(). This is inconsistent with other similar lines in the file and standard JavaScript/TypeScript conventions.

Suggested change

const loginCallback = vi.fn()

const loginCallback = vi.fn();

Copilot · 2025-11-18T20:59:24Z

tests/AuthManager.test.ts

-
-        const manager = AuthManager.initialize('http://auth-server.com/', 'example-realm', 'http://myapp.com/callback', stateChange);
+      const currentCallCount = (localStorage.getItem as Mock)
+        .mock?.calls?.length;


The optional chaining on .mock?.calls?.length could return undefined, but currentCallCount is used in arithmetic at line 125. This will result in NaN if the mock hasn't been called yet. Consider using a fallback value: const currentCallCount = (localStorage.getItem as Mock).mock?.calls?.length ?? 0;

Suggested change

.mock?.calls?.length;

.mock?.calls?.length ?? 0;

Copilot · 2025-11-18T20:59:24Z

src/utils/pkce.ts

+let nodeCrypto: typeof import("crypto") | undefined;
+
+if (typeof window === "undefined") {
+  nodeCrypto = await import("crypto");


[nitpick] Top-level await is used here, which requires the module system to support it. While this works with modern ESM, consider wrapping this in a try-catch block to handle potential import failures gracefully, especially since this is a critical initialization step.

SAUTHC-14 | Replace deprecated crypto usage

cfafd7b

amrography added 2 commits November 6, 2025 10:13

SAUTHC-14 | replace deprecated jsonwebtoken package

a584727

amrography requested review from Abdallah-Abdelkhalek, HassanElZarkawy and SirNarsh and removed request for Abdallah-Abdelkhalek and HassanElZarkawy November 6, 2025 12:58

amrography self-assigned this Nov 17, 2025

SirNarsh requested review from Copilot and removed request for Abdallah-Abdelkhalek November 17, 2025 09:34

Copilot started reviewing on behalf of SirNarsh November 17, 2025 09:35 View session

Copilot finished reviewing on behalf of SirNarsh November 17, 2025 09:37

Copilot AI reviewed Nov 17, 2025

View reviewed changes

src/AuthManager.ts Outdated Show resolved Hide resolved

src/AuthManager.ts Outdated Show resolved Hide resolved

src/AuthManager.ts Show resolved Hide resolved

src/AuthManager.ts Show resolved Hide resolved

amrography added 5 commits November 17, 2025 22:07

SAUTH-14 | Replace Jest with Vitest for testing configuration

d8de050

SAUTH-14 | build packages with tsup

adfd9d3

SAUTH-14 | refactor(utils): implement PKCE code verifier and challeng…

f6c1ae6

…e generation

SAUTHC-14 | build: Update package.json for ES module support and opti…

5be09e8

…mize build process

SAUTH-14 | Update CI/CD workflow to use newer Node.js versions

c803870

SirNarsh requested a review from Copilot November 18, 2025 20:58

Copilot AI reviewed Nov 18, 2025

View reviewed changes

SirNarsh approved these changes Nov 18, 2025

View reviewed changes

SirNarsh merged commit e4de60f into main Nov 18, 2025
4 checks passed

feature/SAUTHC-14 | Replace deprecated crypto usage #13

feature/SAUTHC-14 | Replace deprecated crypto usage #13

Uh oh!

Conversation

amrography commented Nov 6, 2025

Uh oh!

codecov bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Nov 6, 2025 •

edited

Loading