feature/SCKT-6 | Add the option of passing response type parameter to methods #7
Conversation
MostafaFawzy7
requested review from
Abdallah-Abdelkhalek,
HassanElZarkawy,
MMGAbdelhay,
SirNarsh and
amrography
README.md
Outdated
| }; | ||
|
|
||
| ApiKitClient.post<User>('/users', newUser) | ||
| ApiKitClient.post<User>('/users', newUser, 'json') |
There was a problem hiding this comment.
I prefer the third argument to be an object, because later it will give us flexibility to add extra options.
There was a problem hiding this comment.
Also do we need to have the full known Content-Type like: application/json, application/xml ... ? or default axios config request accept your format ?
There was a problem hiding this comment.
default axios config
There was a problem hiding this comment.
I am what is the default response type json or application/json ?
There was a problem hiding this comment.
Content-Type: application/json
Response-Type: json or what the user to decide!
|
Looks good, did you test it locally ? |
It doesn't matter as the entire |
No description provided.