Open
Conversation
|
Why are you doing this piecemeal? I would expect to import all the FreeBSD code needed, and then start to commit on top of it. You also need to mark which revision of FreeBSD you are picking the code from, so in the future we can sync their changes. |
|
Ok, now that I've downloaded the diff I can see the changes you've made compared to the FreeBSD original in zfssubr.c. Please fix the PR to first commit all the unmodified FreeBSD code that you'll need. Then issue your changes as a separate pull request so we can comment on them.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following scripts to the code base
lz4.h: compression support
zfs_bootenv.h: Define macros for label bootenv nvlist pair keys.
zfs_bootenv_os.h: Define macros for label bootenv nvlist pair keys.
zfssubr.c: checksum, compression and raidz support