fix(dialog): clean up keymaps when dialog closes #218
Merged
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dialog class was failing to clean up its keymaps (j, k, <Up>, <Down>, <CR>, <Esc>, 1-9) when torn down. This caused keymaps to accumulate on the output buffer, leaving it in an inconsistent state that could interfere with other keymaps including <C-c> for cancel and j/k for moving up and down. Root cause: vim.keymap.set() returns true/nil, not a keymap identifier. The code was storing these useless return values and then trying to use them as key names in vim.keymap.del(), which silently failed. Fix: Store the actual key binding strings (e.g., "j", "<CR>") instead of the return value, then use those strings to properly delete the keymaps during cleanup. Also added a buffer validity check to prevent errors when cleaning up after the buffer has been deleted.
Owner
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dialog class was failing to clean up its keymaps (
j,k,<Up>,<Down>,<CR>,<Esc>,1-9) when torn down. This caused keymaps to accumulate on the output buffer, leaving it in an inconsistent state that could interfere with other keymaps including<C-c>for cancel andj/kfor moving up and down.Root cause: vim.keymap.set() returns true/nil, not a keymap identifier. The code was storing these useless return values and then trying to use them as key names in vim.keymap.del(), which silently failed.
Fix: Store the actual key binding strings (e.g.,
"j","<CR>") instead of the return value, then use those strings to properly delete the keymaps during cleanup. Also added a buffer validity check to prevent errors when cleaning up after the buffer has been deleted.