Make :Iawriter command accept an optional 'dimension' parameter#4
Draft
leogama wants to merge 1 commit intosubnut:masterfrom
Draft
Make :Iawriter command accept an optional 'dimension' parameter#4leogama wants to merge 1 commit intosubnut:masterfrom
leogama wants to merge 1 commit intosubnut:masterfrom
Conversation
…ass it to :Goyo command
subnut
reviewed
Feb 23, 2021
|
|
||
| fun! vim_iawriter#toggle() " {{{1 | ||
| call <SID>toggle() | ||
| fun! vim_iawriter#toggle(dimension=v:none) " {{{1 |
Owner
There was a problem hiding this comment.
dimension=v:none is currently not supported in neovim and older vim versions.
Owner
|
No need to work on this PR right now. I shall pick it up later. |
Owner
|
If somebody else also needs this feature, comment below. It may cause this PR to be implemented sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass an optional parameter to Goyo to specify the window dimensions in the command, independent of configuration. Tested and working.