Add key filter to ignore keys from being registered by the KeyCombinator... #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor. It provides a new options field 'filterKeys' which takes an array of key chars according to what KeyCombinator returns from its function getKeyChar(keyCode). eval_key_event() has been modified to return null in case the evaluated key is in the options.filterKeys array.
Author
|
Anything wrong with my changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small change to provide key filtering. I have yet to come up with a way to preserve default behaviour. Maybe you have advise? Basically I would like to preserve default behaviour of Tab (switch focus) and Enter (submit form).
....
It provides a new options field 'filterKeys' which takes an array of key
chars according to what KeyCombinator returns from its function
getKeyChar(keyCode).
eval_key_event() has been modified to return null in case the evaluated
key is in the options.filterKeys array.