Search interface #155
Merged
Search interface #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register SEARCH_CONTENT hook and implement simple_search to return posts whose title contains the query, ordered by updated_at. Import Post at module level and replace the TYPE_CHECKING Post alias with django.db.models for typing
Include plugin-logic to enable the search method to be swapped out.
- search_title returns the page title for search results - search_url returns the URL used for searching - search_form renders a search form - search_errors renders some HTML that displays errors with the search query
Includes logic to dispatch the search view
Also remove noisy debug logs from the search flow
Use unittest.mock.patch to simulate registry.run_hook returning None or a QuerySet
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151