refactor: simplify API by replacing StartingContext with Started signal #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove StartingContext() to prevent misuse with long-running operations
- Add Started() <-chan struct{} for signaling when Run() is called
- Add CallbackErr type for structured error reporting with callback names
- Add Name() option for explicit callback identification
- Add callerLocation() for automatic callback naming (file:line)
- Move signal test to separate file with //go:build !windows
- Update documentation to reflect two-phase lifecycle (running, teardown)
This is a breaking change that simplifies the mental model:
- Context() is the app lifetime context
- TeardownContext() bounds cleanup time
- Started() signals readiness (useful for health probes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.