[refactor] Simplification of st.graphviz_chart rendering logic
#12296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Contributor
✅ PR preview is ready!
|
sfc-gh-lwilby
added
security-assessment-completed
sfc-gh-lwilby
changed the title
st.graphviz_chart rendering logic
sfc-gh-lwilby
commented
Aug 26, 2025
| # avoid flakiness. | ||
| expect(first_graph_svg).not_to_have_attribute("width", "79pt") | ||
| # Wait for fullscreen mode to be active by checking the position style | ||
| expect(fullscreen_frame).to_have_css("position", "fixed") |
Collaborator
Author
There was a problem hiding this comment.
These changes are needed because we don't remove the width anymore so we need some other styling change to detect the change to fullscreen for test resiliency.
mayagbarnes
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This logic was originally added here to fix a bug with fullscreen rendering. While working on height for
st.graphviz_chart, I have found it does not seem to be necessary any longer, I have not noticed the described issues after removing the code. This may be because of the changes that have been made toStyledElementContainerincluding the min-width styling which was added to fix issues with returning from full screen for other elements.GitHub Issue Link (if applicable)
Testing Plan
Existing tests. There is a snapshot test that covers the original bug.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.