Change function modifiers and condition checking instruction#16
Open
chrsow wants to merge 2 commits intostonecoldpat:masterfrom
chrsow:master
Open
Change function modifiers and condition checking instruction#16chrsow wants to merge 2 commits intostonecoldpat:masterfrom chrsow:master
chrsow wants to merge 2 commits intostonecoldpat:masterfrom
chrsow:master
Conversation
Owner
|
Hey thanks for doing this! I'll test out the changes (and check everything is working with latest solidity) before committing them |
|
@chrsow, how did you compile smart contract? Because I also tried to compile in Etherium Wallet and received warning message: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two changes in the commit
require()andassert()instead ofthrowfor condition checkingrequire()andassert().Those two function will refunds gas in case of an error occurs.
Ref: http://solidity.readthedocs.io/en/develop/control-structures.html#error-handling-assert-require-revert-and-exceptions
pureinstead ofconstantviewandpurewhich has more clear leading word thanconstant.Ref: http://solidity.readthedocs.io/en/develop/miscellaneous.html#modifiers