Skip to content
This repository was archived by the owner on May 21, 2020. It is now read-only.

Comments

prevent closing Drawer after press scroll#58

Open
DmytroSkrypnyk wants to merge 1 commit intostoeffel:masterfrom
DmytroSkrypnyk:prevent_closing_Drawer_after_press_scroll
Open

prevent closing Drawer after press scroll#58
DmytroSkrypnyk wants to merge 1 commit intostoeffel:masterfrom
DmytroSkrypnyk:prevent_closing_Drawer_after_press_scroll

Conversation

@DmytroSkrypnyk
Copy link

Hi, guys. I have found one issue in this library.
When you start to scroll Drawer it closes and doesn't want to open again.
please check the video -https://monosnap.com/file/Nrl5yRmEKy9c4SrC9s2hcKpCk2Q45c
demo - https://react-motion-drawer.netlify.com/

It's my first PR in forage library so if I make some mistake please just let me know and I'll fix everything.

@DmytroSkrypnyk DmytroSkrypnyk force-pushed the prevent_closing_Drawer_after_press_scroll branch from cf86a88 to 8050f66 Compare August 22, 2019 20:11
@Redmega
Copy link
Collaborator

Redmega commented Sep 4, 2019

I'm not able to replicate on chrome dev tools or a pixel 3 in landscape mode. Whats the specific circumstances that trigger this issue?

@DmytroSkrypnyk
Copy link
Author

I need to render Drawer on all laptops and in my case, I have a lot of items in my nav list so there is always scrollbar. When a user tries to scroll the Drawer as I show on the video below they have the same bug as you can see on the video. (Drawer automatically closes and the user can't open Drawer anymore)
https://monosnap.com/file/IU05Dwu6d0erbpcZG68d4UBDxRBCqm

@Redmega
Copy link
Collaborator

Redmega commented Sep 9, 2019

@DmytroSkrypnyk I understand that, I should have been more specific:

OS: ?
Browser & Version: ?

@DmytroSkrypnyk
Copy link
Author

@Redmega sorry for the misunderstanding
OS: Windows 10; Browser & Version: Google Chrome. Version 76.0.3809
OS: macOS Mojave; Browser & Version: Google Chrome. Version 76.0.3809.132
OS: macOS Mojave; Browser & Version: Safari. Version12.1.2
I can't reproduce this bug only on Firefox.

@Redmega
Copy link
Collaborator

Redmega commented Oct 2, 2019

I'm not able to reproduce at all.

I welcome anyone else to chime in if they can reproduce.

@0xori
Copy link

0xori commented Apr 13, 2020

@Redmega I can reproduce it, this is a little bit tricky because if you scroll using a touchpad it will not happen.
You need to actually scroll by pressing on the scroll bar.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants