Skip to content

v1.5.8#312

Open
jhollway wants to merge 3 commits intomainfrom
develop
Open

v1.5.8#312
jhollway wants to merge 3 commits intomainfrom
develop

Conversation

@jhollway
Copy link
Collaborator

@jhollway jhollway commented Feb 18, 2026

Description

  • Fixed generic arguments and rely on dplyr::tibble() instead of tibble::tibble() internally
  • Fixed fict_marvel example

Checklist:

  • Documentation
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
    • Date in DESCRIPTION is correct
    • Longer functions are commented inline or broken down into helper functions to help debugging
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Description above itemizes changes under subsection titles, e.g. "## Data""
    • Closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"

Copilot AI review requested due to automatic review settings February 18, 2026 19:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the package version to 1.5.8 and fixes several issues related to generic method implementations and example code. The changes ensure consistency with broom package conventions and fix an infinite recursion bug.

Changes:

  • Standardized tibble creation by switching from tibble::tibble() to dplyr::tibble() throughout the codebase
  • Fixed function signatures and column names in tidy/glance/summary methods for sienaFit objects to follow broom conventions
  • Commented out summary.ergm() to prevent infinite recursion through tidy.ergm()
  • Updated fict_marvel example to use correct dataset and transformation pipeline

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DESCRIPTION Bumped version from 1.5.7 to 1.5.8
NEWS.md Added entry for v1.5.8 with description of fixes
R/class_models.R Fixed tidy/glance/summary methods for sienaFit; commented out problematic summary.ergm
NAMESPACE Removed summary.ergm export; added dplyr::tibble import
R/model_tests.R Updated fict_marvel example code
man/tests.Rd Updated documentation with corrected fict_marvel example

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants