Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the package version to 1.5.8 and fixes several issues related to generic method implementations and example code. The changes ensure consistency with broom package conventions and fix an infinite recursion bug.
Changes:
- Standardized tibble creation by switching from
tibble::tibble()todplyr::tibble()throughout the codebase - Fixed function signatures and column names in tidy/glance/summary methods for sienaFit objects to follow broom conventions
- Commented out
summary.ergm()to prevent infinite recursion throughtidy.ergm() - Updated
fict_marvelexample to use correct dataset and transformation pipeline
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DESCRIPTION | Bumped version from 1.5.7 to 1.5.8 |
| NEWS.md | Added entry for v1.5.8 with description of fixes |
| R/class_models.R | Fixed tidy/glance/summary methods for sienaFit; commented out problematic summary.ergm |
| NAMESPACE | Removed summary.ergm export; added dplyr::tibble import |
| R/model_tests.R | Updated fict_marvel example code |
| man/tests.Rd | Updated documentation with corrected fict_marvel example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dplyr::tibble()instead oftibble::tibble()internallyfict_marvelexampleChecklist: