Default params for NBody and PSE #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain, in which case it gets set to 0.
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
Contributor
Author
|
Should be good to go once! |
RaulPPelaez
approved these changes
Sep 11, 2025
Contributor
RaulPPelaez
left a comment
RaulPPelaez
left a comment
There was a problem hiding this comment.
Who does not love some good defaults? Lgtm thanks. Wanna do a release? 1.1.0 id say
Contributor
|
I think the formatting bot is still mad at you |
Contributor
Author
|
I think I just pushed two formatting commits back-to-back (since I failed to read what files needed formatting) and confused the bots. I reran it and think it's good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63 by making it possible to initialize NBody without calling setParameters() and PSE without specifying shear strain.