Remove uses of std::string from exception throwing#21
Remove uses of std::string from exception throwing#21swuerl wants to merge 2 commits intostinos:masterfrom
Conversation
|
I'm again very confused about the CI, the missing reference exists here, also in the |
|
Dynamic linking with msvc or similar is different than for gcc: functions/data needs to be exported explicitly. Typical solution would be to add the missing function to micropython\ports\windows\msvc\exports.def which is annoying because it is in a separate repository.. Could be fixed with a pre-build event, but I've just added it to the windows-pyd branch so if built again this should now link fine. |
06b2ab2 to
0cfb1e1
Compare
0cfb1e1 to
fa6a119
Compare
|
Appveyor seems to have just updated their toolchain so this is now failing on micropython/micropython#16352.. |
|
Ah makes sense. Thank you for looking into it, was just trying to figure out what's going on there. I'll see if I can spin up a VM for windows testing; I'm currently relying on the CI here |
This uses the micropython-internal
mp_obj_new_exception_msg_vargto format exception strings rather thanstd::stringconcatenation. Also changed the<class>_localsstring to use micropython-native string concatenation.