netbox2aquilon: Add support for LAG interfaces#40
Merged
Conversation
jrha
force-pushed
the
lag_interfaces
branch
9 times, most recently
from
71ecf4e to
4a16479
Compare
Member
|
I'm not sure of the purpose of the changes to test_aquilon.py, it just seems to rearrrange the parameters for some existing tests and there doesn't seem to add a test that test the LAG support works. |
Member
Author
|
Good catch on the missing test, thanks! |
jrha
force-pushed
the
lag_interfaces
branch
5 times, most recently
from
a4b9454 to
bff8921
Compare
LAGs or bond interface take their MAC from their child interfaces, so this requires allowing interfaces without MAC addresses as well as ensuring that the --mac argument isn't passed during their creation.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LAGs or bond interface take their MAC from their child interfaces, so this requires allowing interfaces without MAC addresses as well as ensuring that the
--macargument isn't passed during their creation.