Add support for typed arrays and match Godot 4 formatting.#13
Open
bolinfest wants to merge 1 commit intostevearc:masterfrom
Open
Add support for typed arrays and match Godot 4 formatting.#13bolinfest wants to merge 1 commit intostevearc:masterfrom
bolinfest wants to merge 1 commit intostevearc:masterfrom
Conversation
Owner
|
I'm happy to merge this! Would just require:
I think that the CI has rotted a bit in general. I'll see if I can get it back to a green state on master |
Author
|
@stevearc if you can get CI healthy on master, then I'm happy to add tests! |
Owner
|
@bolinfest builds are working on master again |
theMagicalKarp
added a commit
to theMagicalKarp/godot_parser
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using this project to parse my
.tscnfiles on Godot 4, which required some updates here to make things work:.tscnfiles seem to be saved without spaces around args, soExtResource("7")instead ofExtResource( "7" )polygons = Array[PackedInt32Array]([PackedInt32Array(0, 1, 2, 3), PackedInt32Array(4, 0, 3, 5)])that did not seem to be accounted for in the existing grammar, so I had to add new rules invalues.pyand aGDTypedArrayclass to parse these new types into.PackedStringArray()), so made the arg list forobj_typeoptionalThis isn't well-tested, but empirically, it works for my purposes, so feel free to adapt as you see fit! Even if this isn't upstreamed, perhaps it will help someone else.